Fluidsynth cannot load patch files from unicode folders properly

ZDoom / ZMusic

GZDoom's music system as a standalone library

https://forum.zdoom.org/index.php

60 stars 32 forks source link

Fluidsynth cannot load patch files from unicode folders properly #41

Open madame-rachelle opened 1 year ago

madame-rachelle commented 1 year ago

To reproduce, simply do a "mklink /j (your-gzdoom-folder) 試験" from the command line, then cd into 試験 and run GZDoom from there.

coelckers commented 1 year ago

FluidSynth's file handling code is a mess. From the looks of it it should be UTF-8 but with this code it is hard to tell if some of it does not,work.

coelckers commented 1 year ago

Or maybe it's the double slash...?

madame-rachelle commented 1 year ago

The best way that I can think of to address this is to throw the patch set into a temporary folder and load it from there - even if it is via a symlink - but there is no guarantee that symlinks will be available in any temporary storage, nor that the temporary storage will be behind an ascii-conforming path name. This may have to be addressed directly in fluidsynth itself.