search

ZDoom / ZMusic

GZDoom's music system as a standalone library
https://forum.zdoom.org/index.php
60 stars 32 forks source link

cmake: add script to find system GME #5

Closed ghost closed 4 years ago

ghost commented 4 years ago

Add a CMake script to find the includes for the system GME, allowing zmusic to be built using the system GME with cmake -DFORCE_INTERNAL_GME=OFF ..

coelckers commented 4 years ago

The system GME is blocked because of sound looping problems that have been fixed in our copy. Unless someone can confirm that the upstream repo has these fixes this won't get re-enabled. This issue has resulted in repeated bug reports for GZDoom.

ghost commented 4 years ago

Have the GME fixes been sent upstream?

alexey-lysiuk commented 4 years ago

At the moment of update to 0.6.2, the fix already exists in GME's master branch. Part of it was included with the update, a missing piece was added later. GME 0.6.3 has the given changes as well, although nobody knows what else it may break. There are way too many music formats to test. Moreover, things like this are rather annoying.

coelckers commented 4 years ago

Past history here has clearly shown that we need a stable reference for this library. Linking against the system library does not provide that.

This is really something Linux users need to understand. We cannot and will not deal with the whims of developers who are incapable of providing a stable and reliable product. Every single time we updated GME there were regressions. So, if you are dead set on linking against the system version, feel free to, but don't make it easier than necessary for those who do not know what they are doing.