Add `find_library` for GME library.

ZDoom / ZMusic

GZDoom's music system as a standalone library

https://forum.zdoom.org/index.php

60 stars 32 forks source link

Add `find_library` for GME library. #9

Closed ericonr closed 3 years ago

ericonr commented 3 years ago

Hi! I'm looking into packaging ZMusic for Void Linux, now that GZDoom depends on it. There is support for linking a system GME, but I couldn't find how to force it. I ended up patching out the internal gme stuff, and passing -DGME_INCLUDE_DIR=/usr/include -DGME_LIBRARIES=gme when running cmake. Is there a better way?

I noticed zlib had find_library( zlilb ), but gme didn't.

Thanks!

coelckers commented 3 years ago

This is entirely by design because the version we use is not identical with the official one. There were some issues with some song formats not looping properly but it looks like this got deliberatly broken upstream. But it's an issue we do not want, so this was intentionally blocked.

ericonr commented 3 years ago

Oh, should it be removed from the CMake file, then? I might have been poking too much, but it would be good to know that a system gme isn't recommended at all. The option could even be removed from there, I think.