ZDoom / gzdoom

GZDoom is a feature centric port for all Doom engine games, based on ZDoom, adding an OpenGL renderer and powerful scripting capabilities
http://zdoom.org
GNU General Public License v3.0
2.47k stars 540 forks source link

[BUG] Launcher checkbox selection frames are too big and overlap with each other. #2558

Closed Acts19quiz closed 4 months ago

Acts19quiz commented 5 months ago

GZDoom version

GZDoom g4.12.2

Which game are you running with GZDoom?

Other

What Operating System are you using?

Windows 10

Please describe your specific OS version

Windows 10 LTSC

Relevant hardware info

Intel 6700k, Nvidia 980 Ti

Have you checked that no other similar issue already exists?

A clear and concise description of what the bug is.

When using the GZDoom Launcher, the check boxes in the "Options" tab are too wide. Specifically, the 'collision boxes' (to borrow a video game term) are set at widths of 200 pixels, while the visual 'sprites' (in this case, what you see as check boxes and text) are set at 190. This causes the boxes to slowly intrude on the boxes to the right, where it eventually gets to the point that the rightmost check boxes changes the values of the middle column, and users must deliberately click out of bounds to get the desired switches.

The middle row is also somewhat afflicted, though less so than the right edge.

Launcher_frame Here's a picture showing the horizontal 'click frames' and what boxes they correspond to. You can see the overlap start and the windows slowly drift as you go further to the right.

https://github.com/ZDoom/gzdoom/blob/9129f0121b0b9facbcbee0eb5f82afbb0e67b022/src/launcher/settingspage.cpp#L164 The solution is to shrink double panelWidth = 200.0; in settingspage.cpp. My personal choice is 160.0 to both clear the boxes to the right, as well as provide enough buffer so that misclicks that are a few pixels to the left of the visual box don't accidentally trigger the boxes to the left. Realistically, most people aren't clicking anywhere near 150 pixels to the right of the visual checkbox to get what they want.

Steps to reproduce the behaviour.

Explain how to reproduce

  1. Start GZDoom with the Launcher present.
  2. Go to the "Options" tab.
  3. Try to check and uncheck the various boxes, notably the middle ones and most notably the right ones.

Your configuration

N/A

Provide a Log

N/A