search

ZDoom / gzdoom

GZDoom is a feature centric port for all Doom engine games, based on ZDoom, adding an OpenGL renderer and powerful scripting capabilities
http://zdoom.org
GNU General Public License v3.0
2.33k stars 528 forks source link

Narrow Launcher check box clickable areas (address issue #2558) #2559

Closed Acts19quiz closed 1 month ago

Acts19quiz commented 2 months ago

Fix issue #2558 by narrowing the Launcher check box clickable areas on their right edges. They extend too far to the extent that clicking on some check boxes will actually change the values of the boxes to their immediate left.

160 is chosen to not only eliminate this overlap, but provide a few extra pixels of buffer space in case of mis-clicks five or so pixels to the left of the intended check box (so that they don't accidentally change the boxes to the left).

RicardoLuis0 commented 1 month ago

have you checked if the new size is wide enough for all translations?

Acts19quiz commented 1 month ago

Interesting note about that (all translations).

g12_Launcher_new_size Here's the size as I've narrowed it. The collision boxes no longer overlap, and there's a tiny bit of wiggle room to the left of the check boxes in case of mis-clicks.

Since it was brought up, and for reference, here's what happens with other translations: g12_Launcher_language_edit It makes no difference--the visual areas are the same width, and the longer text strings in some translations causes text clipping. That's an entirely separate issue, but I don't know how to fix that short of redesigning the launcher altogether to be wider and accommodate other languages' wider strings. That's another issue for another time, of course. Here, this just addresses the issue of clicking on one column of check boxes affecting the fields to its left.

RicardoLuis0 commented 1 month ago

seems good then