ZDoom / gzdoom

GZDoom is a feature centric port for all Doom engine games, based on ZDoom, adding an OpenGL renderer and powerful scripting capabilities
http://zdoom.org
GNU General Public License v3.0
2.33k stars 526 forks source link

Fix am_cheat modes 4-6 using SecretWallColor instead of WallColor #2572

Closed XaserAcheron closed 1 month ago

XaserAcheron commented 1 month ago

Waaaay back when am_cheat 4 was added, the intent was to show the automap as if it were fully explored by the player (I'd dig up a source, but the search function on the new ZDoom forum software doesn't want to play ball). Current versions of GZDoom break this somewhat by drawing Secret-flagged lines with SecretWallColor when am_cheat 4 is active, which also has the probably-unintended side effect of hiding these lines entirely when using one of the traditional color presets (since they don't define a SecretWallColor -- could be that's a separate bug?). Probably just an oversight when SecretWallColor was added.

This lil' PR restores the intended behavior, since it's extremely useful as a debug tool for doing automap cleanup work (i.e. you can preview the whole map as it will look for a non-cheating player, without having to noclip around everywhere). am_cheat modes 1 through 3 are untouched.