search

ZDoom / gzdoom

GZDoom is a feature centric port for all Doom engine games, based on ZDoom, adding an OpenGL renderer and powerful scripting capabilities
http://zdoom.org
GNU General Public License v3.0
2.33k stars 526 forks source link

[Feature] Add system searching for WebP #2608

Closed Hex4dec closed 1 week ago

Hex4dec commented 1 week ago

GZDoom version

CMakeLists.txt from g14.12.2

Which game are you running with GZDoom?

None

What Operating System are you using?

None

If Other OS, please describe

No response

Relevant hardware info

No response

Is your feature request related to a problem? Please describe.

There is no FORCE_INTERNAL_WEBP or for that matter, any system searching for the webp library.

Describe the solution you'd like

It would be nice if there would be a FORCE_INTERNAL_WEBP flag I could disable so I can use the system WebP library. I trust my package manager more than GZDoom.

Describe alternatives you've considered

No response

Add any other context or screenshots about the feature request here.

No response

RicardoLuis0 commented 1 week ago

pretty sure you can revert these 3 commits to make it use the system libraries: 26fe8f020e71d2a03ac8f8ca112fceb792458dda 648b1a1f26086de1a5558fe7d2b895e75f54c628 140ad88003c6748e569f1c997471c0a20de23d07

RicardoLuis0 commented 1 week ago

(i'll also add it to cmake, but will take a bit of testing/time)

Hex4dec commented 1 week ago

The reason for it being internal-only (or even internal-optional) is quite ridiculous. Package managers are supposed to do their job and you shouldn't worry about it. If vcpkg's package "breaks overnight", you shouldn't touch it and instead yell at vcpkg's maintainers to fix it.

Anyway, thank you.

RicardoLuis0 commented 1 week ago

the reason for using vcpkg was to simplify package management on windows, since vcpkg broke, vcpkg was removed and the library was embedded

coelckers commented 1 week ago

Note: If you revert those 3 commits you void your warranty.

Of course we could change it, but why should we make things harder for us by haviing to deal with third party induced problems?

Hex4dec commented 6 days ago

Like it isn't already voided by the GPL, ha