search

ZECmate / ZECmate-swing-wallet

ZECmate Swing Wallet is a desktop GUI wallet for Zcash
https://swing.zecmate.com
MIT License
6 stars 3 forks source link

Does not generate sprout addresses on macOS, Linux #6

Closed TheTrunk closed 6 years ago

TheTrunk commented 6 years ago

Originally it was extensively tested on windows but unix system needs to have sprout specified there instead of just nothing "" eventhough its default. Changing "" to "sprout" fixes sprout address generation but obviously break transparent address generation.

So the change might be as following

String strResponse = this.executeCommandAndGetSingleStringResponse((isZAddress ? "z_" : "") + "getnewaddress", (isZAddress ? (isSapling ? "sapling" : "sprout") : ""));

Commit that introduced the bug is attached. https://github.com/ZECmate/ZECmate-swing-wallet/commit/674763287bb32f3b6a12fc75b0810a9c33cee633#diff-0c5fb71d087c4909b8360e0354bc00a0R527

This will be very soon reflected in upcoming version 1.0.1

TheTrunk commented 6 years ago

Version 1.0.1 containing fix described is released.