search

ZEGOCLOUD / zego_uikit_prebuilt_call_flutter

MIT License
16 stars 15 forks source link

Add Complete Flutter 3.10.5 support also Add Material You 3.0 #15

Closed fisforfaheem closed 8 months ago

fisforfaheem commented 1 year ago

Adding material 3.0 inside the priject will help a lot

yoer commented 1 year ago

as i knows, just set useMaterial3: true inside ThemeData of YOUR MaterialApp, this will change the regular Material Design of your app to the latest Material 3 design.

import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

// This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        useMaterial3: true,
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

What can I do to assist you?

fisforfaheem commented 1 year ago

Thanks, I already did, but is this package using material 3.0? In other words

On Mon, Jul 17, 2023, 8:51 AM yoer @.***> wrote:

as i knows, just set useMaterial3: true inside ThemeData of YOUR MaterialApp, this will change the regular Material Design of your app to the latest Material 3 design.

import 'package:flutter/material.dart'; void main() { runApp(const MyApp()); } class MyApp extends StatelessWidget { const MyApp({Key? key}) : super(key: key); // This widget is the root of your application. @override Widget build(BuildContext context) { return MaterialApp( title: 'Flutter Demo', theme: ThemeData( useMaterial3: true, primarySwatch: Colors.blue, ), home: const MyHomePage(title: 'Flutter Demo Home Page'), ); } }

— Reply to this email directly, view it on GitHub https://github.com/ZEGOCLOUD/zego_uikit_prebuilt_call_flutter/issues/15#issuecomment-1637337303, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIRXJSEC6IIPMSRL24DIJW3XQSZF7ANCNFSM6AAAAAA2JAWPDY . You are receiving this because you authored the thread.Message ID: @.*** com>

yoer commented 1 year ago

Thanks, I already did, but is this package using material 3.0? In other words … On Mon, Jul 17, 2023, 8:51 AM yoer @.> wrote: as i knows, just set useMaterial3: true inside ThemeData of YOUR MaterialApp, this will change the regular Material Design of your app to the latest Material 3 design. import 'package:flutter/material.dart'; void main() { runApp(const MyApp()); } class MyApp extends StatelessWidget { const MyApp({Key? key}) : super(key: key); // This widget is the root of your application. @OverRide Widget build(BuildContext context) { return MaterialApp( title: 'Flutter Demo', theme: ThemeData( useMaterial3: true, primarySwatch: Colors.blue, ), home: const MyHomePage(title: 'Flutter Demo Home Page'), ); } } — Reply to this email directly, view it on GitHub <#15 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIRXJSEC6IIPMSRL24DIJW3XQSZF7ANCNFSM6AAAAAA2JAWPDY . You are receiving this because you authored the thread.Message ID: @. com>

To support Material 3.0, is there anything I can do to help? I noticed that the zego_uikit_prebuilt_call_flutter package does not use the MaterialApp widget internally.

Could you let me know if there's anything I can do to support Material 3.0?

fisforfaheem commented 1 year ago

No just keep the project updated with latest depedencies

fisforfaheem commented 1 year ago

The Ui kit Icons should match the material UI guidelines, for instance, just look at the new Google home app(irrelevant) but thats the UI google recommends to use

On Mon, Jul 17, 2023 at 9:02 AM yoer @.***> wrote:

Thanks, I already did, but is this package using material 3.0? In other words … <#m-7603209726621074222> On Mon, Jul 17, 2023, 8:51 AM yoer @.> wrote: as i knows, just set useMaterial3: true inside ThemeData of YOUR MaterialApp, this will change the regular Material Design of your app to the latest Material 3 design. import 'package:flutter/material.dart'; void main() { runApp(const MyApp()); } class MyApp extends StatelessWidget { const MyApp({Key? key}) : super(key: key); // This widget is the root of your application. @OverRide https://github.com/OverRide Widget build(BuildContext context) { return MaterialApp( title: 'Flutter Demo', theme: ThemeData( useMaterial3: true, primarySwatch: Colors.blue, ), home: const MyHomePage(title: 'Flutter Demo Home Page'), ); } } — Reply to this email directly, view it on GitHub <#15 (comment) https://github.com/ZEGOCLOUD/zego_uikit_prebuilt_call_flutter/issues/15#issuecomment-1637337303>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIRXJSEC6IIPMSRL24DIJW3XQSZF7ANCNFSM6AAAAAA2JAWPDY https://github.com/notifications/unsubscribe-auth/AIRXJSEC6IIPMSRL24DIJW3XQSZF7ANCNFSM6AAAAAA2JAWPDY . You are receiving this because you authored the thread.Message ID: @. com>

To support Material 3.0, is there anything I can do to help? I noticed that the zego_uikit_prebuilt_call_flutter package does not use the MaterialApp widget internally.

Could you let me know if there's anything I can do to support Material 3.0?

— Reply to this email directly, view it on GitHub https://github.com/ZEGOCLOUD/zego_uikit_prebuilt_call_flutter/issues/15#issuecomment-1637343564, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIRXJSCTSLSS6T4J3EQQZ23XQS2MRANCNFSM6AAAAAA2JAWPDY . You are receiving this because you authored the thread.Message ID: @.*** com>

yoer commented 8 months ago

Which icons do you want to replace? Give me a list and we will provide you with the configuration.

fisforfaheem commented 8 months ago

I meant in general, material you look and feel. Kindly see material guidelines

On Tue, Feb 6, 2024, 9:16 AM yoer @.***> wrote:

Which icons do you want to replace? Give me a list and we will provide you with the configuration.

— Reply to this email directly, view it on GitHub https://github.com/ZEGOCLOUD/zego_uikit_prebuilt_call_flutter/issues/15#issuecomment-1928756276, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIRXJSHOU3WOPTNS4MEH3ZLYSGVDHAVCNFSM6AAAAAA2JAWPD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRYG42TMMRXGY . You are receiving this because you authored the thread.Message ID: @.*** com>

yoer commented 8 months ago

Do you mean to set our interface to material style by default?

But, different users have different needs, and we currently have no plans to invest more in design manpower.

So overall, providing more configuration about styles is the optimal solution.

So if you have any needs, you can let us know.

fisforfaheem commented 8 months ago

Thanks your services are already amazing, but kind of complex..... kindly make the process faster and simpler and remove useless extra stuff needed for the first time.

On Tue, Feb 6, 2024 at 12:45 PM yoer @.***> wrote:

Do you mean to set our interface to material style by default?

But, different users have different needs, and we currently have no plans to invest more in design manpower.

So overall, providing more configuration about styles is the optimal solution.

So if you have any needs, you can let us know.

— Reply to this email directly, view it on GitHub https://github.com/ZEGOCLOUD/zego_uikit_prebuilt_call_flutter/issues/15#issuecomment-1928946276, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIRXJSDZEI6UHV2G5I7CPIDYSHNP3AVCNFSM6AAAAAA2JAWPD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRYHE2DMMRXGY . You are receiving this because you authored the thread.Message ID: @.*** com>

yoer commented 8 months ago

Thank you very much for your compliment. We have been working hard to simplify our customers' work.

There are two aspects of known complexity. One is the most complex offline call configuration, which we currently provide with videos and documents for guidance. The other is because call invitations require page navigation, while in Flutter, you know, context needs to be used. On the above two points, we will try to consider using APIs with more simpler designs.

Also, if you say complex about other aspects, please provide more detailed examples, we would be very grateful to you.

fisforfaheem commented 8 months ago

Thanks :) Good Luck. Hope to see more updates and easier functions soon!

On Thu, Feb 8, 2024 at 11:07 AM yoer @.***> wrote:

Closed #15 https://github.com/ZEGOCLOUD/zego_uikit_prebuilt_call_flutter/issues/15 as completed.

— Reply to this email directly, view it on GitHub https://github.com/ZEGOCLOUD/zego_uikit_prebuilt_call_flutter/issues/15#event-11741157505, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIRXJSEE4K23OUXV6VLMOETYSRTSVAVCNFSM6AAAAAA2JAWPD2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRG42DCMJVG42TANI . You are receiving this because you authored the thread.Message ID: <ZEGOCLOUD/zego_uikit_prebuilt_call_flutter/issue/15/issue_event/11741157505 @github.com>