fix behavior of IXmlNodeRead::GetChildNodeReadonly

ZEISS / libczi

libCZI is an Open Source Cross-Platform C++ library to read and write CZI.

GNU Lesser General Public License v3.0

48 stars 16 forks source link

Description

fix the behavior in case of non-existent path to comply with documentation.

Scrutinize parsing of the path.

add more tests in this respect

add a new method GetStatistics() to ICziWriter-interface

Fixes #108

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

[x] New feature (non-breaking change which adds functionality)

[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

[ ] This change requires a documentation update

Checklist:

[x] I followed the Contributing Guidelines.

[x] I did a self-review.

[x] I commented my code, particularly in hard-to-understand areas.

[ ] I updated the documentation.

[x] I updated the version of libCZI following Versioning of libCZI depending on the type of change

Bug fix -> PATCH
New feature -> MINOR
Breaking change -> MAJOR

[x] I have added tests that prove my fix is effective or that my feature works.

[x] New and existing unit tests pass locally with my changes.

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.18%. Comparing base (87c06cb) to head (42e79aa). Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
Src/libCZI/XmlNodeWrapper.h	95.23%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #109 +/- ## ========================================== - Coverage 66.18% 66.18% -0.01% ========================================== Files 85 85 Lines 10705 10689 -16 ========================================== - Hits 7085 7074 -11 + Misses 3620 3615 -5 ``` | [Flag](https://app.codecov.io/gh/ZEISS/libczi/pull/109/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ZEISS) | Coverage Δ | | |---|---|---| | [windows-latest](https://app.codecov.io/gh/ZEISS/libczi/pull/109/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ZEISS) | `66.18% <96.87%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ZEISS#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ZEISS / libczi