fix build when using a private RapidJSON library

ZEISS / libczi

libCZI is an Open Source Cross-Platform C++ library to read and write CZI.

GNU Lesser General Public License v3.0

48 stars 16 forks source link

Description

The CMake-build failed when using a private RapidJSON-library (i.e. when LIBCZI_BUILD_PREFER_EXTERNALPACKAGE_RAPIDJSON would be false) when attempting to clone the repository because when specifying "GIT_SHALLOW TRUE" it is not possible to use a git-hash as tag. C.f. here. This removes the GIT_SHALLOW specifier, and while at it, switches to the latest version.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

[ ] New feature (non-breaking change which adds functionality)

[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

[ ] This change requires a documentation update

Checklist:

[x] I followed the Contributing Guidelines.

[x] I did a self-review.

[ ] I commented my code, particularly in hard-to-understand areas.

[ ] I updated the documentation.

[x] I updated the version of libCZI following Versioning of libCZI depending on the type of change

Bug fix -> PATCH
New feature -> MINOR
Breaking change -> MAJOR

[ ] I have added tests that prove my fix is effective or that my feature works.

[x] New and existing unit tests pass locally with my changes.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.50%. Comparing base (6b0fbc9) to head (f38bd22). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #117 +/- ## ======================================= Coverage 65.50% 65.50% ======================================= Files 86 86 Lines 10893 10893 ======================================= Hits 7136 7136 Misses 3757 3757 ``` | [Flag](https://app.codecov.io/gh/ZEISS/libczi/pull/117/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ZEISS) | Coverage Δ | | |---|---|---| | [windows-latest](https://app.codecov.io/gh/ZEISS/libczi/pull/117/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ZEISS) | `65.50% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ZEISS#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ZEISS / libczi