search

ZEROFAIL / goblin-legacy

OGM for TinkerPop3 Gremlin Server
Apache License 2.0
23 stars 8 forks source link

Fixed get_existing_indices #6

Closed H-Plus-Time closed 8 years ago

H-Plus-Time commented 8 years ago

index management moved to com.thinkaurelius.titan.graphdb.database.management.ManagementSystem. Any index management, setting of cardinality constraints, property key defs,etc need to go through the aforementioned class.

davebshow commented 8 years ago

Thanks @H-Plus-Time! I haven't started updating the indexing/data modelling functionality yet, but I will start soon and this helps. Before I merge, would you mind updating the test [1]? I know we aren't running it in the travis yet, but it would be nice to start building them up.

  1. https://github.com/ZEROFAIL/goblin/blob/9031f34e7fc7e508efbbbe82771bbaf7e3c9552c/goblin/tests/spec_tests.py#L61
H-Plus-Time commented 8 years ago

The stated purpose of get_existing_indices seems a bit divergent from its test - for the moment I'm assuming that both are concerned with vertex/edge types (rather than indexed property keys); it might be prudent to rename this to get_existing_labels.

Also, the test doesn't pass if there are any extant labels; from looking at the docs, there doesn't appear to be any way of removing an element label, so it might be helpful to note in a testing section of the readme something along the lines of 'make sure to exec titan.sh clean before and after testing, and modify the gremlin-server.yaml to point to a dummy database'.

davebshow commented 8 years ago

I agree, it would be prudent to rename this test. There are many things like this throughout the codebase. Thanks for doing this.