search

ZF-Commons / ZfcBase

A set of generic (abstract) classes which are commonly used across multiple modules. (Formerly EdpCommon)
BSD 3-Clause "New" or "Revised" License
147 stars 98 forks source link

AbstractDbMapper is missing setTableName #73

Closed aadswebdesign closed 9 years ago

aadswebdesign commented 10 years ago

Just found out that Mapper\AbstractDbMapper is missing this. public function setTableName($tableName){ $this->tableName = $tableName; return $this; } Or am I wrong?

adamlundrigan commented 9 years ago

Indeed. ZfcUser's mapper has implemented that itself. Probably should be ported from there to here?

adamlundrigan commented 9 years ago

After some thought I'd prefer to only allow setting the table name on construct, as I don't see the use case for changing the table name on-the-fly (https://github.com/ZF-Commons/ZfcUser/issues/552)

Danielss89 commented 9 years ago

Agree with @adamlundrigan. It doesn't make sense to change the table on-the-fly.

stijnhau commented 9 years ago

any progress on this?