Messages get overridden

[Thinkscape]

Because of https://github.com/ZF-Commons/ZfcUser/blob/master/src/ZfcUser/Authentication/Adapter/Db.php#L78 the Db adapter will override any previously set messages (i.e. when there are other adapters in the chain before it).

We should think about AdapterChainEvent::addMessage() and s/setMessages/addMessage/g.

[adamlundrigan]

Is there a use case for why it shouldn't overwrite?

My concern isthat if you have two adapters, A and B, and A doesn't find a matching user but B does you'll end up with a messages array that looks like this:

// AdapterChainEvent->getMessages()
array(
  'A record with the supplied identity could not be found.',
  'Authentication successful.',
);

Or, if they both fail, this:

// AdapterChainEvent->getMessages()
array(
  'A record with the supplied identity could not be found.',
  'A record with the supplied identity could not be found.',
);

[Thinkscape]

i.e.

1. You have plaintext and facebook adapters.
2. You log in via facebook.
3. Because login/password are empty, plaintext does nothing and returns early.
4. Facebook got creds, but they are invalid - setting "you have not authorized login via facebook" message.