[RFC] Drop dependency on ZfcBase

ZF-Commons / ZfcUser

A generic user registration and authentication module for ZF2. Supports Zend\Db and Doctrine2. (Formerly EdpUser)

BSD 3-Clause "New" or "Revised" License

497 stars 343 forks source link

[RFC] Drop dependency on ZfcBase #560

Open adamlundrigan opened 9 years ago

adamlundrigan commented 9 years ago

With ZfcUser 2.0 targeting PHP 5.5 we can eliminate the need for ZfcBase:

Refactor of mapper layer (#559) eliminates dependency on AbstractDbMapper and MasterSlaveAdapter
Being able to use traits eliminates the need for EventProvider, ProvidesEventsForm, ProvidesEventsInputFilter, as ZF2 bundles an EventManagerAwareTrait for this purpose
No sane person should be using AbstractModule; ZfcUser itself hasn't used it in quite some time.

And that's the sum total of what ZfcBase provides.

Danielss89 commented 9 years ago

Agree, no need for ZfcBase with 5.5 and #559.

telkins commented 8 years ago

Is anyone working on this? I may be wrong, but it appears to be necessary in order to resolve #642 ZF3 Compatibility.

stijnhau commented 8 years ago

If we merge my refactoring of dev master we dropped the need of zfcBase. With @Danielss89 changes for version 2.x we cureenlty duplicate those code to prevent BC breakes

stijnhau commented 7 years ago

@Danielss89 I think this can be closed

adamlundrigan commented 7 years ago

This file has a ZfcBase namespace: https://github.com/ZF-Commons/ZfcUser/blob/3.x/src/ZfcUser/Db/Adapter/MasterSlaveAdapter.php

The README.md still lists ZfcBase as a dependency (but composer.json doesn't)

stijnhau commented 7 years ago

But is that namespoace still needed cant' we just rename it?