search

ZF-Commons / ZfcUser

A generic user registration and authentication module for ZF2. Supports Zend\Db and Doctrine2. (Formerly EdpUser)
BSD 3-Clause "New" or "Revised" License
495 stars 343 forks source link

do not allow 5.6 failures and add php7 to test matrix #624

Closed svycka closed 8 years ago

texdc commented 8 years ago

I'd allow 5.4 and 5.5 to fail.

svycka commented 8 years ago

Why? If this those versions are supported? On Mar 4, 2016 10:32 PM, "George Cooksey" notifications@github.com wrote:

I'd allow 5.4 and 5.5 to fail.

— Reply to this email directly or view it on GitHub https://github.com/ZF-Commons/ZfcUser/pull/624#issuecomment-192456256.

texdc commented 8 years ago

They're EOL.

On Mar 4, 2016, at 2:39 PM, Vytautas Stankus notifications@github.com wrote:

Why? If this those versions are supported? On Mar 4, 2016 10:32 PM, "George Cooksey" notifications@github.com wrote:

I'd allow 5.4 and 5.5 to fail.

— Reply to this email directly or view it on GitHub https://github.com/ZF-Commons/ZfcUser/pull/624#issuecomment-192456256.

— Reply to this email directly or view it on GitHub.

stijnhau commented 8 years ago

Oke that they are EOL. But this is a existing versions that only will be updated.

Could you also create a PR with same change for the master branch?

stijnhau commented 8 years ago

Can this be merged? And can the same PR be created for the master branch?

stijnhau commented 8 years ago

@Danielss89 Is that the correct label? 1.4.1 is already released even an 1.4.2 I think this should have the label 1.5.0

Danielss89 commented 8 years ago

Whoops. Changed tag to 1.4.3

stijnhau commented 8 years ago

Indead 143 is even better 150 can be for racatored servicelocater thingie