Fix Service Manager DI. Change tests

ZF-Commons / ZfcUser

A generic user registration and authentication module for ZF2. Supports Zend\Db and Doctrine2. (Formerly EdpUser)

BSD 3-Clause "New" or "Revised" License

497 stars 343 forks source link

Fix Service Manager DI. Change tests #634

Closed marinovdf closed 8 years ago

stijnhau commented 8 years ago

There is already a pr for this on the v1 branch. THere still needs to be PR created for the master branche

svycka commented 8 years ago

It's the same for all classes I haven't looked at tests but if they pass that's a good sign :D

svycka commented 8 years ago

@stijnhau master branch is for 2.0 and can contain BC break so this whole initializers thing can be removed. Maybe better create another a little bit different PR for master.

stijnhau commented 8 years ago

@svycka Agreed but we already have https://github.com/ZF-Commons/ZfcUser/pull/627 for the v1 And nothing fot the master branch. Ik looking at my planning to do iot myself.

svycka commented 8 years ago

@stijnhau but this PR is for 1.x branch

@marinovdf wants to merge 1 commit into ZF-Commons:1.x from marinovdf:sm_fix

Danielss89 commented 8 years ago

Fixed in #637