search

ZF-Commons / ZfcUser

A generic user registration and authentication module for ZF2. Supports Zend\Db and Doctrine2. (Formerly EdpUser)
BSD 3-Clause "New" or "Revised" License
495 stars 343 forks source link

Login-failed error misplaced within formElementErrors #640

Open intellent opened 8 years ago

intellent commented 8 years ago

Hey everyone,

I noticed an odd behavior, regarding the “Authentication failed. Please try again.” message, after having entered wrong credentials in the login form. The message is rendered within the $this->formElementErrors($element) call of the identity element. To me this seems semantically incorrect, since it’s not an error of the identity element but of the form itself. Furthermore it doesn’t look good, if a global error is rendered within the context of a form field.

I investigated the code and found out that the message is actually send via FlashMessenger here.

This looks right. But my flash messenger does not render the message in its appropriate place. Instead it ends up in the formElementErrors. I have no idea why.

Regards André

jarrettj commented 7 years ago

Can't get error displaying as well. +1