Closed roelvanduijnhoven closed 6 years ago
This PR tries to make the (shared) event system functional again under ZF3. See #678. It addresses all these points by:
EventManagerAwareInterface
.EventManager
directly ourselves on the AdapterChain
method such that events set in the factory are not lost.AdapterChainEvent
to listeners of AdapterChain
. This is in line with how it was under ZF2 and does not require hacks.With these fixes our app functions the way it did before. The only change was to replace the init
events with a delegator for those forms.
The tests do need to be updated. But wanted to get some feedback first about if this will be merged. @Danielss89 What do you think about this?
Would love to hear some feedback @Danielss89, maybe @netiul? Now working of a patched version myself; but not ideal!
Looks good to me. Haven't tested this yet though.
This can be removed from adapters and AdapterChain: use Zend\EventManager\EventInterface;
These changes work for me. @Danielss89 could you merge the request?
@Danielss89 poke on this? :)
Thanks! :+1:
Thanks @Danielss89 a bunch: much appreciated. Now I can stop with working based of strange forks and branches. Could you perhaps release a new version?
What about releasing a new version @Danielss89 ?
See comment below.