ZF-Commons / ZfcUser

A generic user registration and authentication module for ZF2. Supports Zend\Db and Doctrine2. (Formerly EdpUser)
BSD 3-Clause "New" or "Revised" License
497 stars 343 forks source link

Fix broken event system #677

Closed roelvanduijnhoven closed 6 years ago

roelvanduijnhoven commented 6 years ago

See comment below.

roelvanduijnhoven commented 6 years ago

This PR tries to make the (shared) event system functional again under ZF3. See #678. It addresses all these points by:

With these fixes our app functions the way it did before. The only change was to replace the init events with a delegator for those forms.

The tests do need to be updated. But wanted to get some feedback first about if this will be merged. @Danielss89 What do you think about this?

roelvanduijnhoven commented 6 years ago

Would love to hear some feedback @Danielss89, maybe @netiul? Now working of a patched version myself; but not ideal!

Danielss89 commented 6 years ago

Looks good to me. Haven't tested this yet though.

olexp commented 6 years ago

This can be removed from adapters and AdapterChain: use Zend\EventManager\EventInterface;

These changes work for me. @Danielss89 could you merge the request?

asgrim commented 6 years ago

@Danielss89 poke on this? :)

asgrim commented 6 years ago

Thanks! :+1:

roelvanduijnhoven commented 6 years ago

Thanks @Danielss89 a bunch: much appreciated. Now I can stop with working based of strange forks and branches. Could you perhaps release a new version?

zluiten commented 5 years ago

What about releasing a new version @Danielss89 ?