search

ZF-Commons / ZfcUserDoctrineORM

Doctrine2 ORM storage adapter for ZfcUser.
BSD 3-Clause "New" or "Revised" License
89 stars 92 forks source link

Revert mapping #36

Closed bakura10 closed 11 years ago

bakura10 commented 12 years ago

I've seen that a PR has been made to change the original "id" to "user_id". However I think this is wrong, because when dealing with relationships, Doctrine assume that the target entity has an identifier whose name is "id", otherwise, you need to modify the mapping for the JoinColumn.

I think the name should map to what Doctrine does "out-of-the-box", that is to say considering the id is called "id".

bakura10 commented 11 years ago

I close. I can live with that (just changing JoinColumn everywhere), although it would have been better to respect default mapping.