Package has a 0.* constraint on DoctrineORMModule, while version 1.0 has been released

ZF-Commons / ZfcUserDoctrineORM

Doctrine2 ORM storage adapter for ZfcUser.

BSD 3-Clause "New" or "Revised" License

89 stars 92 forks source link

Package has a 0.* constraint on DoctrineORMModule, while version 1.0 has been released #97

Closed DannyvdSluijs closed 7 years ago

DannyvdSluijs commented 8 years ago

In the composer.json on line 25 [https://github.com/ZF-Commons/ZfcUserDoctrineORM/blob/master/composer.json#L25] you can see the doctrine-orm-module constraint is set to 0.* whilst version 1.0.0 is available.

angurova commented 8 years ago

I have the same problem

Kwido commented 8 years ago

Had the same issue. Forked it (https://github.com/Kwido/ZfcUserDoctrineORM) , fixed it and made a PR: #98. Feel free to use my fork untill it's fixed or create your own fork and fix it for the time being.

Haven't found any problems on upgrading the version of docrine-orm-module. Works like a charm!

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/Kwido/ZfcUserDoctrineORM.git"
        }
    ],

pensiero commented 8 years ago

@Kwido the PR #98 is closed, why?

Kwido commented 8 years ago

@pensiero as a commit is already on the master branch setting the doctrine-orm-module version to 1.0+

pensiero commented 8 years ago

@Kwido however the v1.0.1 is 2 commit behind master, and it doesn't include the requirement of doctrine/doctrine-orm-module ~1.0

@Danielss89 can you release a v1.0.2 that contains those commit?

Thanks

pensiero commented 7 years ago

@Danielss89 or anyone have permission: any news about the creation of the new release? Actually I have dev-master on my composer, that it's not really nice for a production environment.

Thanks

pensiero commented 7 years ago

Anybody?

andrewdisney commented 7 years ago

Danielss89 commented 7 years ago

Tagged 1.0.2

pensiero commented 7 years ago

@Danielss89, the v1.0.2 needs a commit on ZfcUser released on the master branch but not tagged: https://github.com/ZF-Commons/ZfcUser/compare/1.4.4...1.x

Can you tag a new release also in ZfcUser? Thanks a lot

pensiero commented 7 years ago

Anybody?

Danielss89 commented 7 years ago

I will take a look tonight and tag ZfcUser

pensiero commented 7 years ago

Thanks @Danielss89

pensiero commented 7 years ago

I took a look better, maybe that's not the problem. If I specify:

    "zf-commons/zfc-user-doctrine-orm": "1.0.*",

it says:

( ! ) Fatal error: Uncaught Error: Call to undefined method ZfcUser\Options\ModuleOptions::getEnableDefaultEntities() in /var/www/vendor/zf-commons/zfc-user-doctrine-orm/Module.php on line 16

I saw that there is no getEnableDefaultEntities() in the ModuleOption.php file, even in the latest version of ZfcUser, but there is a getEnableDefaultEntities() method inside the ModuleOption.php of ZfcUserDoctrineORM... maybe my config is wrong somewhere?

pensiero commented 7 years ago

I reported the error also here last month: https://github.com/Kwido/ZfcUserDoctrineORM/compare/master...ZF-Commons:master

pensiero commented 7 years ago

Temporary I solved this way:

    "zf-commons/zfc-user": "1.*",
    "zf-commons/zfc-user-doctrine-orm": "1.0.*",

But as @Kwido said here I think that probably is better to specify that constraint inside the composer of this project.

PS: it's not necessary to tag ZfcUser now