ZF-Commons / zfc-rbac

Role-based access control module to provide additional features on top of Zend\Permissions\Rbac
BSD 3-Clause "New" or "Revised" License
181 stars 111 forks source link

Change ZF2 dependency in composer #1

Closed davidwindell closed 12 years ago

davidwindell commented 12 years ago

As ZF2 is now stable, many people will be requiring specific or at least released version of ZF in their composer.json.

Can we change the dev-master requirement to 2.* or 2.0.*?

Thinkscape commented 12 years ago

Good idea.

davidwindell commented 12 years ago

Doh, Rbac didn't get merged into 2.0.3, my mistake.

That said, the requirement should be changed to dev-develop until it makes it into dev-master then 2.1?

Thinkscape commented 12 years ago

Rbac won't get into ZF2 for quite some time. I'm not sure there's a point of pushing it into 2.1 either. I'd say it's fine where it is for now, so composer.json should point at minimal zf2 version that is required for Rbac module to work correctly (which is probably 2.0.0).

davidwindell commented 12 years ago

@Thinkscape there is no Rbac in 2.0.0-3 so this module doesn't work, see;

Fatal error: Class 'Zend\Permissions\Rbac\Rbac' not found in zfc-rbac/src/ZfcRbac/Service/Rbac.php on line 261

davidwindell commented 12 years ago

Maybe @SpiffyJr can update this module to rely on his Rbac implementation until Permissions\Rbac is merged into a release?

weierophinney commented 12 years ago

@Thinkscape RBAC is already in the development branch and slated for 2.1, which is scheduled for release next month. On Oct 23, 2012 4:06 AM, "Artur Bodera" notifications@github.com wrote:

Rbac won't get into ZF2 for quite some time. I'm not sure there's a point of pushing it into 2.1 either. I'd say it's fine where it is for now, so composer.json should point at minimal zf2 version that is required for Rbac module to work correctly (which is probably 2.0.0).

— Reply to this email directly or view it on GitHubhttps://github.com/ZF-Commons/ZfcRbac/issues/1#issuecomment-9698020.

ghost commented 12 years ago

I'll make the branches follow latest stable + appropriate tagging when ZF2 2.1 is released. For now, I've merged the PR from @davidwindell to follow zf2 develop.