ZF-Commons / zfc-rbac

Role-based access control module to provide additional features on top of Zend\Permissions\Rbac
BSD 3-Clause "New" or "Revised" License
181 stars 111 forks source link

[3.0] What do we need? #253

Open bakura10 opened 10 years ago

bakura10 commented 10 years ago

Once various PR from @jmleroux are merged, we can start talking about ZfcRbac 3, so that we can allow some BC breaks.

In overall, I'm very happy with the work we've done in ZfcRbac 2.x, and it proved to be super stable, powerful and efficient, so thank you everyone for the great ideas.

Dependencies

For ZfcRbac 3, I'm still wondering about dependencies. We have no valid reason to raise the minimum PHP version to 5.5, but:

At the same time, as ZfcRbac is a widely used module, raising the dependency two versions upper than the framework it is based on may be a bit frustrating for a lot of users.

RBAC

ZfcRbac is based on a ZF3 prototype (https://github.com/zf-fr/rbac) and I think we can say with some good confidence that the component is very good and that integrating it into ZF3 will not be a problem.

I don't have any idea about what kind of change could we do (excepting removing some now useless interfaces like PermissionInterface one).

ZfcRbac

Do you have other features, BC... that you would like in ZfcRbac 3 ?

ping @spiffyjr @jmleroux @ocramius @arekkas @danizord

jmleroux commented 10 years ago

At the same time, as ZfcRbac is a widely used module, raising the dependency two versions upper than the framework it is based on may be a bit frustrating for a lot of users.

For my clients in France, 5.3 is still the most widespread version. 5.4 is growing fast, but 5.5 is still very low. So it's not only a problem regarding the framework version, but also compared to clients environments.

IMHO, we should keep 5.4 as the requirement.

aeneasr commented 10 years ago

IMHO, we should keep 5.4 as the requirement.

I agree, PHP 5.3 doesn't provide patches for bugs any more, only for security issues. So it would actually be a good way of telling people: Upgrade your PHP! However, moving on 2 versions could potentially break a lot of stuff in legacy apps, so I agree with the 5.4 raise.

jmleroux commented 10 years ago

moving on 2 versions

We already require 5.4.

jmleroux commented 10 years ago

Do you have other features, BC... that you would like in ZfcRbac 3 ?

A "develop" branch

aeneasr commented 10 years ago

We already require 5.4.

Haha, my bad.

Annotation: I'm not considering to have this for ZfcRbac 3.0. This is a lot of work and needs a lot of thinking about how it should be used, both from a usability and performance point of view.

I agree, especially because annotations are unlikely to bc break, as they are a completely new feature.

bakura10 commented 10 years ago

Ok, let's keep 5.4 as dependency.

I've created a develop branch that is aliased to 3.0

atans commented 10 years ago

php cli search permission name from .php, .phtml which file contains isGranted("permission.name") or auto update permission names to permission table of database Like doctrine orm:schema-tool:update

jmleroux commented 10 years ago

php cli search permission name from .php, .phtml which file contains isGranted("permission.name")

Sort of ZfcRbacDiagnostics ?