search

ZF-Commons / zfc-rbac

Role-based access control module to provide additional features on top of Zend\Permissions\Rbac
BSD 3-Clause "New" or "Revised" License
181 stars 111 forks source link

Start deleting #308

Closed bakura10 closed 8 years ago

bakura10 commented 8 years ago

Hi everyone (special ping to @danizord and @arekkas )

This is the first step of my cleaning work as explained in https://github.com/ZF-Commons/zfc-rbac/issues/307

As said there, the goal is to make zfc-rbac no longer a ZF2 module, but a simpler library based on middleware paradigm (ZfcRbac 2.x will still be supported as a ZF2 library).

As a consequence, a lot of features do not make sense anymore. Guards for now will be removed but we may rethought them around middleware paradigm.

The first step of this PR is to simply remove features and make the tests pass.

bakura10 commented 8 years ago

Damn, making the tests pass will be a huge mess considering that we wrote them by trying to initialize a ZF2 module (...).

Therefore I think I'll need to merge as it and fix that in a future PR.

Is there anything you think could be removed?

danizord commented 8 years ago

module.config.php could be removed as well?

bakura10 commented 8 years ago

You're right!