search

ZF-Commons / zfc-rbac

Role-based access control module to provide additional features on top of Zend\Permissions\Rbac
BSD 3-Clause "New" or "Revised" License
181 stars 111 forks source link

Only require some part of ZF 2 #32

Closed bakura10 closed 11 years ago

bakura10 commented 11 years ago

Hi,

@spiffyjr , ocramius is doing something interesting in some of his module, I think we could do the same here, but I need your point of view. Instead of setting a dependency to the whole zendframework framework (https://github.com/ZF-Commons/ZfcRbac/blob/master/composer.json#L19), it could be good to have only dependencies with the part of the framework we are using (so in the case of ZfcRbac, zend-servicemanager, zend-permissions and may be one or two others).

What do you think ? This way people who want to use ZfcRbac as a standalone can do it without downloading tons of unused files.

spiffyjr commented 11 years ago

That's fine. Last time I tried that it tried downloading the entire package anyway so feel free to submit a PR.

weierophinney commented 11 years ago

@spiffyjr It only does that if you forget the repo, or specify a dev minimum-stability. Also, if the project requires all of zf, that "replaces" individual components specified in modules.

On Friday, December 21, 2012, Kyle Spraggs wrote:

That's fine. Last time I tried that it tried downloading the entire package anyway so feel free to submit a PR.

— Reply to this email directly or view it on GitHubhttps://github.com/ZF-Commons/ZfcRbac/issues/32#issuecomment-11630242.

Matthew Weier O'Phinney matthew@weierophinney.net http://mwop.net/

spiffyjr commented 11 years ago

I'll set this up when I tag the release version. Thanks.