search

ZF-Commons / zfc-rbac

Role-based access control module to provide additional features on top of Zend\Permissions\Rbac
BSD 3-Clause "New" or "Revised" License
181 stars 111 forks source link

Tests fixes - pass on ZF2 and ZF3 #349

Closed michalbundyra closed 7 years ago

michalbundyra commented 7 years ago

As noted in https://github.com/ZF-Commons/zfc-rbac/issues/348#issuecomment-253732132 there were some errors in tests. I've fixed it to pass on ZF2 and ZF3 modules.

I'd prefer also to update travis configuration, to have something similar as we have in ZF/Apigility modules: https://github.com/zendframework/zend-view/blob/master/.travis.yml or https://github.com/zfcampus/zf-hal/blob/master/.travis.yml

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 92.825% when pulling 5d006cb347674339eb2988a29ad0e54116b52253 on webimpress:hotfix/tests into b47e9a2d8baf36d579eda26b25d0c0a30a6a170d on ZF-Commons:master.

bakura10 commented 7 years ago

Thanks. This fixed the issue here.