search

ZF-Commons / zfc-rbac

Role-based access control module to provide additional features on top of Zend\Permissions\Rbac
BSD 3-Clause "New" or "Revised" License
181 stars 111 forks source link

Update ControllerPermissionsGuard add condition check #359

Open Itach1Uchixa opened 7 years ago

Itach1Uchixa commented 7 years ago

ControllerPermissionsGuard add condition check

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.3%) to 91.605% when pulling d2b6e9f592bab91dbeb97f721549ea1f23ed8d93 on Itach1Uchixa:master into 48df720a3670dbc36d57bf98f8e1827206431656 on ZF-Commons:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.3%) to 91.605% when pulling d2b6e9f592bab91dbeb97f721549ea1f23ed8d93 on Itach1Uchixa:master into 48df720a3670dbc36d57bf98f8e1827206431656 on ZF-Commons:master.

prolic commented 7 years ago

Coverage decreased, some more tests?

Itach1Uchixa commented 7 years ago

I don't understand what causes this error, I think it's because I added some new unit tests. Help me!

basz commented 7 years ago

The reason you get an error is because you've added code... so on average the score when drown

Itach1Uchixa commented 7 years ago

As I understand it is not a error or big problem, right?

basz commented 7 years ago

Correct it is not an error, nor a 'big' problem.

However, we kindly request tests are written for all code that is added.

edit: You can run ./vendor/bin/phpunit src/ZfcRbac/Guard/ControllerPermissionsGuard.php --coverage-html ./build to generate a local report of the code that is covered. The report can be viewed in your browser.