Develop - Githubissues

ZF-Commons / zfc-rbac

Role-based access control module to provide additional features on top of Zend\Permissions\Rbac

BSD 3-Clause "New" or "Revised" License

181 stars 111 forks source link

Develop #366

Closed basz closed 6 years ago

basz commented 7 years ago

switch to php7
add return typehint
switch phpunit 6
include zfr-rbac in library
adds header check
switch travis notifications

svycka commented 7 years ago

https://github.com/container-interop/container-interop is deprecated maybe we can switch to https://github.com/php-fig/container

basz commented 6 years ago

what was the reason to not use zend rbac and implement internal thing?

I think https://github.com/bakura10/rbac was suppost to replace zendframwork-zend-rbac at some point. We had a discussion with bakura10 and he agreed to allow it to copy it into the repo as is.

prolic commented 6 years ago

I'm okay with merging both PR's https://github.com/ZF-Commons/zfc-rbac/pull/366 & https://github.com/ZF-Commons/zfc-rbac/pull/379. I'll do another review over the whole code base again, it's probably easier to check then these large pull requests.

basz commented 6 years ago

@svycka Your reviews helped me get this one going. thanks for the swift reviews!