Multiple assertions develop

ZF-Commons / zfc-rbac

Role-based access control module to provide additional features on top of Zend\Permissions\Rbac

BSD 3-Clause "New" or "Revised" License

181 stars 111 forks source link

Multiple assertions develop #379

Closed basz closed 6 years ago

basz commented 6 years ago

Implements https://github.com/ZF-Commons/zfc-rbac/pull/320 for develop branch

does so without performance loss if not used
assertion sets may be nested with different conditions
does so lazily for each condition
- an AND condition will break early as soon as one assertions fails
- an OR condition will break early as soon as one assertions succeed
assertions are cached, so a next call won't require to construct an assertion or AssertionSet.

documentation forthcoming

basz commented 6 years ago

no sure why this PR also show commits already pulled into develop.

review request is from commit e7fd215 and forward

DavidHavl commented 6 years ago

Looks great!!

basz commented 6 years ago

@svycka thanks. yes, I will do additional changes like php71, remove zf2 support etc... for now could you have a look at the changes from commit e7fd215 and forward?

svycka commented 6 years ago

@svycka thanks. yes, I will do additional changes like php71, remove zf2 support etc... for now could you have a look at the changes from commit e7fd215 and forward?

@basz I already did, but if you could rebase would be a lot easier to review because now it is very hard to see relevant changes.

basz commented 6 years ago

I now figured out what goed wrong. this PR https://github.com/ZF-Commons/zfc-rbac/pull/366 isn't merged into develop yet. Guess I should fix that one first and then rebase this one.

svycka commented 6 years ago

@basz or you can remove commits before e7fd215 also should work

prolic commented 6 years ago

Looks good so far, just some minor notes