Plugin managers refactor and more improvements

[svycka]

this way we could make another step to decouple from Zend service-manager and fully support any PSR-11 implementation. If everyone agrees I will continue with RoleProviderPluginManager maybe more don't remember if we have more :D

I guess would be a good idea to change config

ZfcRbac\Assertion\AssertionPluginManager::class => ZfcRbac\Container\AssertionPluginManagerFactory::class,
// to
ZfcRbac\Assertion\AssertionContainerInterface::class => ZfcRbac\Container\AssertionPluginManagerFactory::class,

Also not sure about naming maybe ZfcRbac\Assertion\ContainerInterface or ZfcRbac\Container\AssertionContainerInterface

what do you think? @prolic @basz

[svycka]

I think it's ready for review and I am waiting for answers to my questions

[basz]

Lets keep it then

Op 23 feb. 2018 om 17:23 heeft Vytautas Stankus notifications@github.com het volgende geschreven:

@svycka commented on this pull request.

In src/Container/ObjectRepositoryRoleProviderFactory.php:

@@ -33,8 +34,11 @@ */ final class ObjectRepositoryRoleProviderFactory for me, it's not that hard to create a factory so I would say remove. And maybe if they have config somewhere else or something they anyway have to create it. But for most people, this is enough so don't know remove or no.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[svycka]

I have added tests and if we decide to keep 'role_provider' config then its ready to merge unless someone sees something bad.

[basz]

great work, so much removed!