search

ZFIN / zebrafish-anatomical-ontology

Ontology describing the anatomy of Danio rerio from a single cell to adult fish. The namespace of the ontology is zebrafish_anatomical_ontology the prefix is ZFA. Updates to ZFA are released every other month. A subset of the ZFS http://purl.obolibrary.org/obo/zfs.obo is packaged with this ontology.
Other
6 stars 6 forks source link

Duplicate labels #165

Open psiotwo opened 1 year ago

psiotwo commented 1 year ago

Two pairs of OWL classes share the same definition.

First pair: ZFA:0000807 ZFA:0000927

Second pair: ZFA:0000944 ZFA:0005112

cerivs commented 1 year ago

This will be fixed in the next release

matentzn commented 1 year ago 
ERROR   duplicate_label larva   rdfs:label  larva
ERROR   duplicate_label larva   rdfs:label  larva
ERROR   duplicate_label juvenile    rdfs:label  juvenile
ERROR   duplicate_label juvenile    rdfs:label  juvenile
ERROR   duplicate_label adult   rdfs:label  adult
ERROR   duplicate_label adult   rdfs:label  adult

Still some duplicate labels:

@cerivs if you want to really get rid of these, you need to rename the obsolete classes as obsolete.

For example, larva should be labelled obsolete larva to avoid name conflicts.

cerivs commented 1 year ago

@matentzn Is his is a new change to policy about naming classes? These were not previously a problem.

matentzn commented 1 year ago

No, these were always a in OBO principles, see https://obofoundry.org/principles/fp-012-naming-conventions.html: having to classes with the same name. There is no 100% rule on how to deal with obsolete class names - some people delete the labels, other just prepend the prefix "obsolete", like in "obsolete larva" to indicate to users that the term is, indeed, obsolete.