search

ZFIN / zebrafish-anatomical-ontology

Ontology describing the anatomy of Danio rerio from a single cell to adult fish. The namespace of the ontology is zebrafish_anatomical_ontology the prefix is ZFA. Updates to ZFA are released every other month. A subset of the ZFS http://purl.obolibrary.org/obo/zfs.obo is packaged with this ontology.
Other
6 stars 6 forks source link

Standardize synonym type definition for PLURAL #173

Closed cthoyt closed 9 months ago

cthoyt commented 10 months ago

We're working towards standardizing synonym type definitions across the OBO Foundry. This involved getting OMO terms for several common synonym type definitions. More information in https://github.com/OBOFoundry/OBOFoundry.github.io/issues/2450.

In this PR, the ad hoc definition in ZFA for PLURAL synonyms is replaced with the standard synonym type definition OMO:0003004 for plural syonyms

CC @ybradford @cerivs

cthoyt commented 10 months ago

Emailed about this on october 31, 2023

cerivs commented 9 months ago

This change breaks the editor so will not merge.

cthoyt commented 9 months ago

@cerivs in f09d190 I added what I think was a missing type definition. Can you see if this fixes the editor?

cerivs commented 9 months ago

Looks like your pull isn't replacing synonyms that are "RELATED PLURAL" with "RELATED OMO:0003004"

cthoyt commented 9 months ago

Looks like your pull isn't replacing synonyms that are "RELATED PLURAL" with "RELATED OMO:0003004"

updated in 0c5aff7. Thanks for being patient

cerivs commented 9 months ago

Yay! Is working now.