search

ZFTurbo / volumentations

Library for 3D augmentations
MIT License
220 stars 35 forks source link

what dimension is the depth channel? #13

Open whisney opened 1 year ago

whisney commented 1 year ago

https://github.com/ZFTurbo/volumentations/blob/50a11936c5a663e0bc203be0f99ca9bb136edbe4/volumentations/augmentations/functional.py#L309

Is there a mistake in the dimension of depth here?

ZFTurbo commented 1 year ago

Why do you think it's mistake? Any of first 3 dimensions can be depth. In this code it's assumed that 3rd dimension is depth.

whisney commented 1 year ago

But the line 259 and line 281 in the same function, it's assumed that 1st dimension is depth.

https://github.com/ZFTurbo/volumentations/blob/50a11936c5a663e0bc203be0f99ca9bb136edbe4/volumentations/augmentations/functional.py#L259

https://github.com/ZFTurbo/volumentations/blob/50a11936c5a663e0bc203be0f99ca9bb136edbe4/volumentations/augmentations/functional.py#L281

ZFTurbo commented 1 year ago

I think it's not really a bug, but 2 different dimensions used for transforms. But need to investigate. Thanks.