fix: autocomplete friendly layout parsing :wrench: - Githubissues

ZGIS / semantique

Semantic Querying in Earth Observation Data Cubes

https://zgis.github.io/semantique/

Apache License 2.0

16 stars 6 forks source link

fix: autocomplete friendly layout parsing :wrench: #41

Closed fkroeber closed 5 months ago

fkroeber commented 5 months ago

Description

This PR ensures that the _parse_layout() function works as intended. Previously, this function was ill-defined (variable k was referenced before assignment) resulting in at least two unintended behaviours:

Parsing of hierarchical layout.json files with more than 2 levels failed, e.g. when calling dc.retrieve("added_level", "appearance", "colortype", extent = extent) instead of dc.retrieve("appearance", "colortype", extent = extent).
The else-part of the function allowed endless iterations.

Type of change

Select one or more relevant options:

[x] Bug fix (change which fixes a bug reported in a specific issue)
[ ] New feature (change which adds a feature requested in a specific issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (improved documentation for existing functionality in the package)
[ ] Repository update (change related to non-package files or structures in the GitHub repository)

Checklist:

[x] I have read and understood the contributor guidelines of this project
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] I ran all demo notebooks locally and there where no errors