AyushAher commented 4 weeks ago

Moved from fstream to fs-extra package, as fstream is no longer supported, and its dependencies contain vulnerabilities.

Changes:

Replaced usage of fstream with fs-extra.
Updated packages to remove and replace vulnerable dependencies

Issues:

261

ZJONSSON commented 4 weeks ago

Thanks @AyushAher, please ensure PR is passing all tests before I can review it. Also please submit PR without style changes for now, only the material code changes required for the replacement library.

AyushAher commented 4 weeks ago

@ZJONSSON Please Check now, I have updated the code as per your comments.

ZJONSSON commented 3 weeks ago

@AyushAher tests are still failing (eslint). Please ensure all tests pass by either running locally or by running github actions on your fork.

Also, please remove the axios code into a separate PR if you want to submit that code. We should not "replace" url source but instead create a new one called axios and also update readme

ZJONSSON commented 3 weeks ago

@AyushAher thank you for actively participating. Your idea of using fs-extra has been implemented here: https://github.com/ZJONSSON/node-unzipper/pull/318

I'm closing this PR because of the following issues:

You are removing all node versions from tests except version 19
You are changing tests so that they pass when there are differences between extracted files and the contents of the archive
You are using fs.ensureFile, which creates an empty file and is not as efficient as fs.ensureDirectory
Axios should not be part of this PR

Thanks again! If you want to pursue Axios, please do so as a separate source (i.e. url should use request and axios should use axios etc).

ZJONSSON / node-unzipper

#261 move away from unmaintained fstream #317

Changes:

Issues:

261