ZJONSSON / parquetjs

fully asynchronous, pure JavaScript implementation of the Parquet file format
MIT License
34 stars 61 forks source link

Properly handle plain values encoding after dictionary pages. #68

Closed SergeyFromHell closed 3 years ago

SergeyFromHell commented 3 years ago

There is a bug in pages processor. If PLAIN-encoding page occurs after we have read dictionary page (and stored dictionary), the dictionary is unconditionally used, which leads to emty (undefined) values. This PR fixes such a case. Also, column with originalType = 'UTF8' now consistently converts to string, not only the dictionary-encoded values.