search

ZJONSSON / parquetjs

fully asynchronous, pure JavaScript implementation of the Parquet file format
MIT License
34 stars 61 forks source link

Support reading Timestamps in node 12 or later #76

Closed lwillmeth closed 2 years ago

lwillmeth commented 2 years ago

The parent library has a bug in node 12 or later, which breaks while reading Timestamps, which are stored as BigInt.

This PR fixes that by first parsing them. Unfortunately it looks like prettier also went nuts, so the relevant change is in lib/types on line 364:

  - return new Date(+value);
  + return new Date(parseInt(value));