search

ZJULearning / ttfnet

Apache License 2.0
485 stars 99 forks source link

Parameter alpha (0.54) multiplied in code but division in paper? #8

Open oliver-batchelor opened 5 years ago

oliver-batchelor commented 5 years ago

In the paper the formula for the gaussian is given: σ = w / 6α

In the code alpha is being multiplied to the radius like so (brackets added to emphasise order of operations)

        h_radiuses_alpha = ((feat_hs / 2.) * self.alpha).int()
        w_radiuses_alpha = ((feat_ws / 2.) * self.alpha).int()

This seems to me that alpha is 1/alpha... excuse me if I'm mistaken!

liuzili97 commented 5 years ago

Thanks! It's a mistake in the paper~