ZK-Garage / plonk

A pure Rust PLONK implementation using arkworks as a backend.
https://discord.gg/XWJdhVf37F
Mozilla Public License 2.0
295 stars 76 forks source link

Traits for Lookup Tables #132

Closed lopeetall closed 2 years ago

lopeetall commented 2 years ago

Currently we have a long and complicated src/lookup/lookup_table.rs with a lot of repeated code which generates lookup tables for add, mul, and xor. As suggested here by @CPerezz we should make a trait for lookup tables and have add, mul etc implement the trait. This can also address this comment from @bhgomes, as each lookup table can implement its own lookup function that knows which columns are to be considered "outputs", if any.

lopeetall commented 2 years ago

duped