search

ZK-Garage / plonk

A pure Rust PLONK implementation using arkworks as a backend.
https://discord.gg/XWJdhVf37F
Mozilla Public License 2.0
289 stars 75 forks source link

Add test for permutation argument constants. #155

Closed davidnevadoc closed 2 years ago

davidnevadoc commented 2 years ago

Close #154

akinovak commented 2 years ago

Wow looks so great and clean! Should we also put a hackmd link on top of the file?

@CPerezz for not I guess it might be ignored, but I think we need to include it as soon as we switch to arbitrary number of wires.

davidnevadoc commented 2 years ago

This runs pretty quick. Takes O(k^2) multiplications with k being the number of wires which its usually not too large. I think right now having the constants hardcoded this is fine to have as a test. If at some point we generate them in some other way this may be part of the generation algorithm.

weikengchen commented 2 years ago

Why is prev_cts never updated?

davidnevadoc commented 2 years ago

Why is prev_cts never updated?

I forgot to update it at the end of the loop. Well spotted! :+1:

weikengchen commented 2 years ago

I feel it is ready to merge.