search

ZK-Garage / plonk

A pure Rust PLONK implementation using arkworks as a backend.
https://discord.gg/XWJdhVf37F
Mozilla Public License 2.0
295 stars 76 forks source link

Adding blinding factors at the circuit level #167

Closed krnak closed 1 year ago

krnak commented 1 year ago

Are you adding blinding factors at the circuit level???

https://github.com/ZK-Garage/plonk/blob/4fc762ac433a942939ad43a3b29050a26ce52533/plonk-core/src/constraint_system/composer.rs#L246

That's a nonsense! Blinding factors should be created per witness, not per circuit.

krnak commented 1 year ago

Ok. I understand the crate design better now. You need a witness for a circuit construction (which is quite weird, but ok), and the you replace this witness by a new witness with fresh blinding factors.