Fix CI missing `uses` parameter in Run clippy

[CPerezz]

In #38 an error was introduced in the CI so that it wasn't possible to run them since they were panicking before starting.

• Edit the CI config and move clippy to a sepparated job.
• Edit the CI config and add global RUSTFLAGS env var.
• Edit the CI config and use better toolchain config.

Resolves: #39

Co-authored-by: Brandon H. Gomes bhgomes@pm.me

[bhgomes]

Looks like we needed to install clippy too using the toolchain commands. Sorry about that.

[CPerezz]

So as always, there are versions of nightly that don't have clippy yet. So for this case, I'll basically set a fixed rustc toolchain version in the CI that overwrites the one from the rust-toolchain file.

[bhgomes]

The other fix is to remove line 25 on src/constraint_system/composer.rs, somehow that redundant import snuck in.

[bhgomes]

I think something like this should work: See next comment.

- uses: actions-rs/toolchain@v1
   with:
     override: false
     profile: minimal
     components: clippy

See: https://github.com/actions-rs/toolchain#components

[bhgomes]

I think this should work, no need to set a specific version in the rust-toolchain file. While we're at it, rust-toolchain is deprecated in favor of rust-toolchain.toml. Ours would be something like:

[toolchain]
channel = "nightly"
components = ["clippy", "rustfmt"]
profile = "minimal"

See: https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file. Then, we can probably leave the CI as is: https://github.com/actions-rs/toolchain#the-toolchain-file.

[bhgomes]

Just need to remove -D warnings from cargo test.

[bhgomes]

Finally all good! Thanks for your patience, sorry about the errors.

[CPerezz]

Finally all good! Thanks for your patience, sorry about the errors.

Thanks to you!!! I appreciate the help and the speed on replying!!