Improve `linearisation_poly` code

davidnevadoc commented 2 years ago

There are some changes that could be made in order to improve the code of linearisation_poly.rs in terms of readability:

[ ] Clearer variable names: Have more descriptive names instead of potentially ambiguous or confusing names (a, b, c, f_1, etc.)
[ ] Descriptive function names: Try to reflect more accurately the purpose of the functions in its names
[ ] Code comments: Add comments detailing which polynomials/ equations are being constructed and other clarifications when necessary

bhgomes commented 2 years ago

This is addressed in #45.

davidnevadoc commented 2 years ago

You are right! I will add the changes I had in mind in the PR and will close this issue when it is merged.

bhgomes commented 2 years ago

~~I have a push that I'm waiting on since I lost push permissions, then you can see if my fixes addressed this issue.~~ I just moved the PR instead.

ZK-Garage / plonk