ZK-Garage / plonk

A pure Rust PLONK implementation using arkworks as a backend.
https://discord.gg/XWJdhVf37F
Mozilla Public License 2.0
295 stars 76 forks source link

Fix `logic.rs` comments #56

Closed davidnevadoc closed 2 years ago

davidnevadoc commented 2 years ago

The logic gates are explained with formulas drawn in the comments. Automatic formatting has shifted this drawings making some of them incomprehensible. Example:

  //                    /                 \          /
  // \  c      - 4 . c  = | a      - 4 . a  | (& OR ^) | b
  // - 4 . b  |   i + 1        i   \  i + 1        i /
  // \  i + 1        i /
  //

Originally:

//                    /                 \          /                 \
//  c      - 4 . c  = | a      - 4 . a  | (& OR ^) | b      - 4 . b  |
//   i + 1        i   \  i + 1        i /          \  i + 1        i /
//
markulf commented 2 years ago

This is still open.

Found these comments in plonk-core/src/constraint_system/logic.rs