search

ZK-Garage / plonk

A pure Rust PLONK implementation using arkworks as a backend.
https://discord.gg/XWJdhVf37F
Mozilla Public License 2.0
295 stars 76 forks source link

Add challenges correctly to the transcript #98

Closed markulf closed 2 years ago

markulf commented 2 years ago

Currently, most transcript.challenge_scalar are only generated, but not added to the transcript. We must do this correctly. Can we test that the implementation matches the specification.

CPerezz commented 2 years ago

If intra-doc links check was failing, how this got merged @LukePearson1 ???

LukePearson1 commented 2 years ago

As remarked in this pull request. There was significant tech debt yesterday with individuals working on a wide array of branches. I tried to fix this break with @bhgomes. However, it proved too pedantic and required further inspection, thus was punted as issue #96. In the meantime, the open stale PR's were merged wrt recent lib developments.

This will be fixed and merged to master before other PR's.

It is also worth noting that this break is directly from plonk-book and was brought about by recent changes to the book. and can be considered modular, or even orthogonal, to the code progression. This seems to be entirely a CI issue.

cc: @CPerezz

markulf commented 2 years ago

There are more challenges beyond beta and gamma. Can I restore this branch and continue with this, or better to create a new branch? When shall the PR revert and restore branch features of github be used? Suspect I forgot to make it a draft PR.

LukePearson1 commented 2 years ago

This is being fixed in PR #84, so no worries.