nus-pe-bot
commented
4 years ago Team's Response
After reviewing the bug report, we have determined that:
- a patient named John Doe was added.
- the patient Joe was already previously discharged so index 1 is not Joe but John Doe.
The User is reporting that the SearchContext for disambiguation of discharge is not being triggered.
To reproduce the bug, we first tried to create the patient and use discharge jo. This is unable to reproduce the bug. To reproduce the behaviour specified, we have to execute the command discharge jo in the PatientContext of John. In the PatientContext, there is no ambiguity in which patient the User is specifying as there is only 1 patient. Hence, no disambiguation will be triggered. After execution, the User will be returned to the HomeContext. A repeat of the command will trigger the disambiguation as there may be multiple Patient's who contain jo in their name.
To summarise, the User triggered the first discharge jo command in the Patient context of the patient. There is no ambiguity to which patient this refers to as there is only 1 Patient in the current context. This returns the User to the HomeContext where there could be multiple Patients which may have jo in their name. Hence, disambiguation is triggered only for the 2nd command and the User is prompted to select 1 of them.
After creating Patients John Doe with bed A103, John Doe with bed 123 and test with bed II and discharge Joe:
After discharging and readmitting John Doe with bed 123:
After opening context of Patient John:
After discharge jo from context of Patient John:
After discharge jo, index 1:
After creating test patient with bed II and discharging:
Reports generated:
Section 4.2.8 in the UG, discharge from the PatientContext:
Section 4.1.5 in the UG, discharge from the HomeContext:
To understand how disambiguation works, please refer to Section 4.2 in the DG:
Section 4.2.2 specifies the details of how the implementation of disambiguation works:
In summary of how disambiguation works:
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [ ] I disagree
Reason for disagreement: [replace this with your reason]
You can see that there is no patient with exact name 'jo' generated in the report, but a random patient is discharged without letting me to select. However if I want to discharge 'jo' the second time, the searching page appears. Not sure what happened to the first discharge.