ZL-Audio / ZLEqualizer

equalizer plugin
https://zl-audio.github.io/plugins/zlequalizer/
GNU General Public License v3.0
261 stars 8 forks source link

[FR]: phase flip and solo fix #104

Closed yonderehco1197 closed 2 weeks ago

yonderehco1197 commented 3 weeks ago

Why?

Hi!

It seems to use a fixed slope and bandwidth for all filter types in solo mode. For example, using a 96db/oct high pass filter and turning on solo I will hear what a 6db/oct filter lets through. Is it possible to make the solo mode reflect the actual slope/bandwidth settings?

What do you want?

Also, would you consider adding a phase flip button? :) It's really missing sometimes.

Thanks!

Code of Conduct

zsliu98 commented 3 weeks ago

Is it possible to make the solo mode reflect the actual slope/bandwidth settings?

Two reasons why I use a 12 dB/oct bandpass as the solo filter:

Therefore, I think a 12 dB/oct bandpass is better, but I may change my mind in the future.

Also, would you consider adding a phase flip button? :) It's really missing sometimes.

Could you explain why you want a phase flip button in an EQ plugin?

yonderehco1197 commented 3 weeks ago

It definitely makes sense from a technical standpoint, it's just weird to hear things in a filter solo that don't actually go into it.

Could you explain why you want a phase flip button in an EQ plugin?

Well, if we already change the phase in all possible ways by simply equalizing the signal, why not just invert it? To me it's like another type of filter. Almost certainly in all DAWs it can be done by standard means, but there is also a standard EQ :) I mean, it's always more convenient to have everything directly related to equalization in one place.

zsliu98 commented 3 weeks ago

It definitely makes sense from a technical standpoint, it's just weird to hear things in a filter solo that don't actually go into it.

Could you explain why you want a phase flip button in an EQ plugin?

Well, if we already change the phase in all possible ways by simply equalizing the signal, why not just invert it? To me it's like another type of filter. Almost certainly in all DAWs it can be done by standard means, but there is also a standard EQ :) I mean, it's always more convenient to have everything directly related to equalization in one place.

That is reasonable. I will add a phase flip button in the Output Setting. As I am working on some other stuff, I will keep this issue open to remind me of this :blush:

zsliu98 commented 3 weeks ago

The phase-flip button has been added to the Output setting panel. As I have not tested it thoroughly & there have been tons of changes on the UI side, please report back if you see any bugs or degraded performance.

ZL Equalizer-0.3.5-Windows-Software.exe.zip

yonderehco1197 commented 3 weeks ago

The new output panel looks cool :) I didn't notice any problems. Thanks for listening to my little request!

zsliu98 commented 2 weeks ago

I am glad that you like it :) I am going to close this issue. Feel free to open another one if you have problems.