ZMYaro / paintz

A simple drawing app that runs in a web browser, designed to be an MS Paint substitute for Chromebooks and other Chrome OS devices. PaintZ is free, but please consider supporting development at https://ko-fi.com/ZMYaro or https://patreon.com/ZMYaro.
https://paintz.app
53 stars 11 forks source link

The canvas can be scrolled when a dialog is open #206

Open ZMYaro opened 3 years ago

ZMYaro commented 3 years ago

Steps to reproduce the behavior

  1. Resize the canvas (or shrink the window) such that it is larger than the window
  2. Open a dialog
  3. Scroll past the end of the dialog scroll area (if any)
  4. The canvas starts scrolling.

Expected behavior Nothing (scrolling stops).

ZMYaro commented 3 years ago

This should probably be fixable by setting the dialog container's overscroll-behavior.

ZMYaro commented 3 years ago

Partially fixed in https://github.com/ZMYaro/paintz/commit/1c59fcec1500c4b48b0c25ed0460c9fe0b17d951.

It appears the context in which it is not fixed may be a bug in Chromium.

ZMYaro commented 3 years ago

Addressed for the splash screen in https://github.com/ZMYaro/paintz/commit/2d30d3b96c097beb3116caa6383d58c97b4b53b9 (presumably, once the Chromium bug is fixed).

ZMYaro commented 1 year ago

I am going to call this as fixed as it can be right now, and it can be addressed further in v4.0, when the scroll context the canvas is in is no longer the whole window.