Browser default keyboard shortcuts work while dialogs are open - Githubissues

ZMYaro / paintz

A simple drawing app that runs in a web browser, designed to be an MS Paint substitute for Chromebooks and other Chrome OS devices. PaintZ is free, but please consider supporting development at https://ko-fi.com/ZMYaro or https://patreon.com/ZMYaro.

https://paintz.app

53 stars 11 forks source link

Browser default keyboard shortcuts work while dialogs are open #217

Closed ZMYaro closed 3 years ago

ZMYaro commented 3 years ago

Need to prevent default behavior PaintZ shortcuts that have conflicting browser functions:

[x] Ctrl+O (Open file)
[x] Ctrl+S (Save page as)
[x] Ctrl+N (New window)
[x] Ctrl+Shift+N (New incognito window (Chrome))

Other notes:

Ctrl+P (print in PaintZ, print in Chrome) is fine because no conflict in function, and dialogs are hidden in print mode anyway.
Ctrl+G (toggle grid in PaintZ, find in Chrome) is fine because users may want to search within dialog text)

(Caught by David Martin.)

ZMYaro commented 3 years ago

Fixed in https://github.com/ZMYaro/paintz/commit/249cfa8e9b9803be48052317e393dcbdf670c562.