search

ZORALab / Hestia

One Peaceful Frontend+Backend Software Library Suite.
https://hestia.zoralab.com
Other
19 stars 1 forks source link

Port All PWA Icons Files Rendering Steps to Render Stage #33

Closed hollowaykeanho closed 1 year ago

hollowaykeanho commented 1 year ago

Description

Please provide a short description of what feature you're looking forward to
enhance below. Please include the story behind your idea as well to give a
better visualization of your idea.

Appearently, the PWA Icons slows down was mainly due to repeated render across EACH page. Let's switch it to root page only mode like how it was done in Issue #29 .

Expected Behavior

Please specify the expected behavior of your requested enhancement. Some great
and helpful pointers are your expected interface (e.g. command patterns,
simple sketches of the user interface, etc).

Icons rendering only done once at root level.

Current Behavior

Please specify the current behavior (e.g. workaround, blockage, etc).

Icons are being rendered repeatedly across each page in the entire repository.

Attachment

Please drag and drop the necessary data files (e.g. screenshot, logs, etc)
below.
hollowaykeanho commented 1 year ago

Completed in 269bd85d9beaf5e5ce36ee234fe377621a62948a

hollowaykeanho commented 1 year ago

Released in https://github.com/ZORALab/Hestia/releases/tag/v1.0.0